Jump to content

Module talk:WikiProject banner

Page contents not supported in other languages.
From Wikipedia, the free encyclopedia

@HouseBlaster and @R'n'B have pointed out a problem with the code for projects that have opted out of PIQA. We are using Module:Pagetype to detect whether a page is an article or some other type of page (e.g. disambiguation pages and redirects are not classified as articles), and this is used to determine whether to use "pages" or "articles" in the category name.

The problem occurs for opt-out projects because they can set their class to be whatever they wish, regardless of the page type. For example C2Cl2F4 is a list article but WikiProject Lists classified it as a disambiguation page. Therefore it is going into Category:Disambig-Class List articles rather than Category:Disambig-Class List pages. — Martin (MSGJ · talk) 08:38, 15 January 2025 (UTC)[reply]

We should distinguish between two things here. What a project classifies a page for their project, and what a page is. WP History can say that in their opinion an article is not the global quality of say "B" and they give it a "C", what they can't do, is say an article is a category. Same thing with disambiguation pages. A page is, or is not, a disambiguation page. That is something that is global. I'm opposed to any and all changes which let projects falsely identify pages. Gonnym (talk) 10:54, 20 January 2025 (UTC)[reply]
It appears the articles in Category:Disambig-Class List articles were just rookie mistakes. They are now in Category:List-Class List articles (not Category:Disambig-Class List pages since, as correctly stated, they are articles). Nurg (talk) 23:40, 20 January 2025 (UTC)[reply]
There are projects that choose to define certain categories as Project-class because they are internal project categories rather than content categories. I'm not sure we should be enforcing such a strict interpretation, to stop them doing that — Martin (MSGJ · talk) 10:33, 21 January 2025 (UTC)[reply]
Well then, start an RfC and lets see where the consensus is. Gonnym (talk) 10:48, 21 January 2025 (UTC)[reply]
I'm not the one trying to change the status quo — Martin (MSGJ · talk) 21:36, 1 February 2025 (UTC)[reply]

See also related discussions at Template talk:WikiProject banner shell#Request: Class=Project to override other default allocations and Template talk:WikiProject Military history#Redlinked class-rating categories, again. I am thinking that we should keep a record of which classes are "pages" and which classes are "articles". Then opt-out projects can do whatever they like without messing up the category system — Martin (MSGJ · talk) 21:39, 1 February 2025 (UTC)[reply]

To do adjustments

[edit]

I have made a few adjustments to the to do related code in /auxiliary/sandbox.

  1. Converted the presentational table to a more appropriate div.
  2. Use a dark mode token for the background.
  3. Removed support for setting custom styles. Template:WikiProject Freemasonry is the only project which uses them (TODO_STYLE TODO_TITLE_STYLE), and the way in which they are used is not friendly for dark mode, though the particular color flavor happens to be readable. I removed another which was using the default in light mode.

It looks like Module:WikiProject banner/templatepage needs removal of the parameters of interest. Izno (talk) 02:10, 5 February 2025 (UTC)[reply]

Great, thanks for the info. I can deal with /templatepage — Martin (MSGJ · talk) 18:15, 5 February 2025 (UTC)[reply]
@Izno there is a slight spacing inconsistency with the new divs, which you can observe on Template:WikiProject Japan/sandbox. Are you able to line up the text on the left and the [show] links on the right? — Martin (MSGJ · talk) 16:43, 22 March 2025 (UTC)[reply]
Playing around with the left/right padding on the container seems to do it. Adding 2px on the left and another 2px on the right I think got it. Basically what's happening is that tables have a natural border-spacing (not coincidentally it's 2px) which is padding like but applied slightly differently. Izno (talk) 16:53, 22 March 2025 (UTC)[reply]
Padding is always inside the border. The spacing outside the border is the margin. See The CSS Box Model. --Redrose64 🌹 (talk) 23:27, 22 March 2025 (UTC)[reply]
Tables are special in that they have the border-spacing property. The point I was making is that in fact there is more to the box model than just padding and margin. Izno (talk) 00:58, 23 March 2025 (UTC)[reply]
I don't see any changes to the sandbox and the example is still looking the same? If you can fix the spacing in the sandbox, I suggest we change all of the collapsible boxes in the module to use div boxes, to keep things consistent — Martin (MSGJ · talk) 08:46, 24 March 2025 (UTC)[reply]
@Izno are you still interested in this? — Martin (MSGJ · talk) 20:48, 28 March 2025 (UTC)[reply]
I didn't make any adjustments, which is why you do not see any changes.
I didn't change the other collapsible boxes because they're more or less fairly marked up as tables, from memory (and memory may be wrong of course). Izno (talk) 21:30, 28 March 2025 (UTC)[reply]
In that case I can't really see a benefit to converting the table to a div, as it will introduce an inconsistency. I have removed the style parameters from /templatepage, so these will now be treated as unknown parameters — Martin (MSGJ · talk) 18:53, 30 March 2025 (UTC)[reply]

DOC=auto Please see

[edit]

Small inconsistency: in the #Deprecated parameters section, both listas & class bullets' 2nd sentence should start with either "Please see ..." or "See ..." and not both. This is the only instance of "Please see ..." I see, so preference goes to "See ...".   ~ Tom.Reding (talkdgaf)  12:00, 8 February 2025 (UTC)[reply]

Eliminating the remaining uses of Template:WPBannerMeta/hooks and its subpages

[edit]

Low hanging fruit

[edit]

From what I can tell, I think we are all set to delete (under WP:T5) the templates listed above, but I am asking here before actually pushing the button. HouseBlaster (talk • he/they) 02:48, 11 February 2025 (UTC)[reply]

Template:WPBannerMeta/hooks/notecounter is mentioned at Module:WikiProject banner/templatepage#L-24. Other than that, the few transclusions left for the others can be deleted. Gonnym (talk) 09:39, 11 February 2025 (UTC)[reply]
I don't want to break that module; can that line just be deleted per WP:BEANS? HouseBlaster (talk • he/they) 23:46, 26 February 2025 (UTC)[reply]
Figured out how to remove it. HouseBlaster (talk • he/they) 23:31, 27 February 2025 (UTC)[reply]

The other remaining subtemplate – Template:WPBannerMeta/hooks/cats (talk · history · transclusions · logs · subpages) – is still in use at Template:WikiProject U.S. Roads/cats. I can see of several possible solutions, in order of increasing complexity:

  1. Leave it be.
    • Pros: Very easy
    • Cons: Feels like we are inviting further use of a deprecated template
  2. Move it to Template:WikiProject U.S. Roads/cats/core (or some other subpage)
    • Pros: Easy, prevents use of the template in other locations
    • Cons: Still leaves around some technical debt
  3. Merge its functionality with Template:WikiProject U.S. Roads/cats

I lean towards option 2. Best, HouseBlaster (talk • he/they) 02:48, 11 February 2025 (UTC)[reply]

2 will be the easiest for now and will allow to decouple it from the parent template. Gonnym (talk) 10:01, 11 February 2025 (UTC)[reply]
I have actioned option 2. HouseBlaster (talk • he/they) 23:32, 27 February 2025 (UTC)[reply]

NA class category warnings

[edit]

While processing a move request for Template:WikiProject Song Contests, and then updating the categories (for the first time), I was caught unaware of the changes to the NA-related categories, Wikipedia:Categories_for_discussion/Log/2024_December_7#Category:Category-Class_articles. This led to an eventual deletion of Category:NA-importance Song Contests articles and Category:NA-Class Song Contests articles as these became redirects to the now non-existent Eurovision categories.

Then in the Template:WikiProject Song Contests page, warnings came up, requesting to create the 'articles' categories, leading to me recreating the redirects to suppress the warnings (cc: @Liz). Can these warnings be suppressed outright in the module codes since the articles are being automatically set to the 'pages' categories already? – robertsky (talk) 23:09, 13 February 2025 (UTC)[reply]

Yes I will update those, thanks for the reminder — Martin (MSGJ · talk) 10:41, 14 February 2025 (UTC)[reply]
 Done, finally got round to this — Martin (MSGJ · talk) 16:09, 22 March 2025 (UTC)[reply]

Pre-load templates

[edit]

We are still using the following templates:

and these are also using:

I would firstly like to move these to a more suitable location (as Template:WPBannerMeta is no longer in use) and also to update and simplify this whole family of templates, because things can be done a lot more easily these days — Martin (MSGJ · talk) 16:16, 22 March 2025 (UTC)[reply]

 Done. I have moved the three preload templates to Template:WikiProject banner preload template and deleted all the rest which are no longer needed — Martin (MSGJ · talk) 18:14, 26 March 2025 (UTC)[reply]

Tidy up intersecting categories

[edit]

I am looking at tidying up the intersecting quality/importance categories and there seem to be 3 types:

— Martin (MSGJ · talk) 07:52, 2 April 2025 (UTC)[reply]

Misplaced banners by bot

[edit]

In January 2024 there was an error in the bot's code which resulted in edits like this. I suspect that most of these have now been fixed but I am still finding the occasional example. So I was wondering if there is a way we could track these. I think that every banner should be above the first h2 heading, so perhaps some pattern that checks whether the banner code is before the first instance of 2 equals signs (==) — Martin (MSGJ · talk) 08:01, 2 April 2025 (UTC)[reply]

Maybe similar code to Module:Is infobox in lead? Gonnym (talk) 08:45, 2 April 2025 (UTC)[reply]
Looks promising — Martin (MSGJ · talk) 09:37, 2 April 2025 (UTC)[reply]